Skip to content

Use grid-stride loop for fill!#691

Merged
maleadt merged 1 commit into
mainfrom
gsfill
May 15, 2026
Merged

Use grid-stride loop for fill!#691
maleadt merged 1 commit into
mainfrom
gsfill

Conversation

@christiangnrd
Copy link
Copy Markdown
Member

AMD and Metal do not support total grid size dimensions >=2^32, leading large fill!s on AMDGPU to fail to launch (bad), and silently fail on Metal (worse).

@vchuravy
Copy link
Copy Markdown
Member

vchuravy commented Mar 3, 2026

Can we add a check to Metal.jl?

@christiangnrd
Copy link
Copy Markdown
Member Author

Can we add a check to Metal.jl?

JuliaGPU/Metal.jl#751

@maleadt maleadt merged commit 48d0f42 into main May 15, 2026
17 of 18 checks passed
@maleadt maleadt deleted the gsfill branch May 15, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants